-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade-14 fixups #8838
Merged
Merged
Upgrade-14 fixups #8838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Putting back in draft until Agoric/agoric-3-proposals#85 is fixed |
mhofman
changed the base branch from
dev-upgrade-14
to
mhofman/8843-core-proposal-upgrade-handler
January 30, 2024 23:02
mhofman
changed the base branch from
mhofman/8843-core-proposal-upgrade-handler
to
mhofman/some-upgrade-14-cherry-pick
January 30, 2024 23:03
mhofman
force-pushed
the
mhofman/fix-up-upgrade-14
branch
from
January 30, 2024 23:03
f71661e
to
c10b121
Compare
mhofman
force-pushed
the
mhofman/some-upgrade-14-cherry-pick
branch
from
January 30, 2024 23:27
4b0644c
to
b350c41
Compare
mhofman
force-pushed
the
mhofman/fix-up-upgrade-14
branch
2 times, most recently
from
January 31, 2024 22:28
38c173e
to
c10274c
Compare
PTAL @turadg I am generating a |
turadg
reviewed
Jan 31, 2024
Base automatically changed from
mhofman/some-upgrade-14-cherry-pick
to
dev-upgrade-14
February 1, 2024 19:10
turadg
approved these changes
Feb 7, 2024
mhofman
force-pushed
the
mhofman/fix-up-upgrade-14
branch
from
February 7, 2024 00:46
3b48d81
to
ceffbcd
Compare
This was referenced Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #8755
Now layered on top of #8842
Description
Fixup a couple issues from #8755
And a new feature:
Security Considerations
None
Scaling Considerations
None
Documentation Considerations
None
Testing Considerations
Existing CI tests
Upgrade Considerations
Forces the wallet factory upgrade as part of the chain upgrade handler